[network-definition-spec] improve keystore keys network spec #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klbrvik
requested review from
pepoviola,
wirednkod and
l0r1s
as code owners
klbrvik
changed the title
No specific reason, I'll change it to |
klbrvik
force-pushed
the
improve-keystore-keys-network-spec
branch
2 times, most recently
from
f2083ff to
af99462
Compare
…types and their schemas
…ed schema by zombienet default to sr schema
klbrvik
force-pushed
the
improve-keystore-keys-network-spec
branch
from
9af244c to
7982570
Compare
|
So currently blocked from fixing. |
This is a known issue, merging now. Thanks for your contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation doesn't allow to create desired keys in node keystore.
Suggested changes are backward compatible and will allow to define custom key types together with their schemas.