Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zombienet ignores --reserved-nodes arg for collators #1360

Closed
skunert opened this issue Sep 20, 2023 · 1 comment · Fixed by #1361
Closed

Zombienet ignores --reserved-nodes arg for collators #1360

skunert opened this issue Sep 20, 2023 · 1 comment · Fixed by #1361

Comments

@skunert
Copy link
Contributor

skunert commented Sep 20, 2023 •
edited
Loading

Issue Description

We have a test in cumulus 0002-pov_recovery that specifies some relay chain arguments for the collator. It is supposed to start with a --reserved-nodes flag. However apparently the CLI flag that was specified in the test toml is not passed to the actual node.

From the logs:

test-parachain --name two --node-key 3fc4ccfe745870e2c0d99f71f30ff0656c8dedd41cc1d7d3d376b0dbe685e2f3 --chain /cfg/rococo-local-2000.json --base-path /data --listen-addr /ip4/0.0.0.0/tcp/30333/ws --prometheus-external --rpc-cors all --unsafe-rpc-external --rpc-methods unsafe --prometheus-port 9615 --rpc-port 9944 -lparachain::availability=trace,sync=debug,parachain=debug,cumulus-pov-recovery=debug,cumulus-consensus=debug --disable-block-announcements --bootnodes /ip4/10.24.23.119/tcp/30333/ws/p2p/12D3KooWRkZhiRhsqmrQ28rt73K7V3aCBpqKrLGSXmZ99PTcTZby --relay-chain-rpc-url ws://ferdie.zombie-b4eaaaff1ff0d70aeb3d08be83227b36.svc.cluster.local:9944 -- --base-path /relay-data --chain /cfg/rococo-local.json --execution wasm --port 39937 --rpc-port 45669

Steps to reproduce the issue

  • happens on Ci

Describe the results you received

--reserved-nodes is not passed

Describe the results you expected

--reserved-nodes is passed

Zombienet version

CI version

Provider

Kubernetes

Provider version

-

Upstream Latest Release

Yes

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

Screenshots

No response
@skunert skunert mentioned this issue Sep 20, 2023
Merged
@pepoviola
Copy link
Collaborator

Hi @skunert, thanks for reporting I will take a look asap.

@alindima alindima mentioned this issue Sep 20, 2023
Closed
@pepoviola pepoviola mentioned this issue Sep 20, 2023
Merged
@pepoviola pepoviola mentioned this issue Sep 20, 2023
Merged
pepoviola added a commit to paritytech/polkadot-sdk that referenced this issue Sep 21, 2023
@pepoviola
bump zombienet version (#1655)
93bb492 
Includes:
- fix for paritytech/zombienet#1360 (root
cause of #1647)
- Improve default concurrency to spawn nodes.

Also, fix `var` name in CI file.

cc @skunert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(orchestrator), fix sanitizing args for cumulus collator paritytech/zombienet
2 participants
@pepoviola @skunert