Skip to content

Commit

Permalink
fix(test-runner): ignore invalid for perform upgrade tx
Browse files Browse the repository at this point in the history
  • Loading branch information
pepoviola committed Nov 24, 2023
1 parent b6b3a71 commit 08f729d
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions javascript/packages/orchestrator/src/jsapi-helpers/chainUpgrade.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,21 @@ async function performChainUpgrade(api: ApiPromise, code: string) {
unsub();
return resolve();
} else if (result.isError) {
console.log(`Transaction Error`);
unsub();
return reject();
if(result.status.isInvalid) {
// Allow `invalid` tx, since we will validate the hash of the `code` later
// The problem being that there are forks
// Block X is build with the tx included
// X gets retracted by Y that doesn't has the tx included
// And thus the tx lands in the tx pool again
// Then another block on top of x is build that tries to include the tx again and boom
// It reports it as invalid, because it was already included
console.log(`Transaction invalid:`, JSON.stringify(result));
return resolve();
} else {
console.log(`Transaction Error:`, JSON.stringify(result));
return reject();
}
}
});
});
Expand Down

0 comments on commit 08f729d

Please sign in to comment.