Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry logic for downloading files from fileserver #283

Merged
merged 2 commits into from
Dec 12, 2024
Merged

add retry logic for downloading files from fileserver #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e780d
add retry logic
pepoviola Dec 12, 2024
ff5be2d
remove unused
pepoviola Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions crates/provider/src/kubernetes/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use k8s_openapi::api::core::v1::{ServicePort, ServiceSpec};
use sha2::Digest;
use support::{constants::THIS_IS_A_BUG, fs::FileSystem};
use tokio::{sync::RwLock, task::JoinHandle, time::sleep, try_join};
use tracing::trace;
use tracing::{debug, trace, warn};
use url::Url;

use super::{
Expand Down Expand Up @@ -464,7 +464,7 @@ where
if !output.contains(hash) {
return Err(ProviderError::DownloadFile(
remote_file_path.to_string_lossy().to_string(),
anyhow!(format!("node: {}, invalid sha256sum for file", self.name())),
anyhow!(format!("node: {}, invalid sha256sum hash: {hash} for file, output was {output}", self.name())),
));
}
} else {
Expand Down Expand Up @@ -636,7 +636,7 @@ where
self.create_remote_dir(&remote_parent_dir).await?;
}

trace!(
debug!(
"Uploading file: {} IFF not present in the fileserver",
local_file_path.to_string_lossy()
);
Expand All @@ -646,13 +646,30 @@ where
let _ = url.set_host(Some("fileserver"));
let _ = url.set_port(Some(80));

let res = self
.download_file(url.as_ref(), remote_file_path, Some(&hash))
.await;
if res.is_err() {
// re-try one time
self.download_file(url.as_ref(), remote_file_path, Some(&hash))
.await?;
// Sometimes downloading the file fails (the file is corrupted)
// Add at most 5 retries
let mut last_err = None;
for i in 0..5 {
if i > 0 {
warn!("retrying number {i} download file {:?}", remote_file_path);
tokio::time::sleep(Duration::from_secs(i)).await;
}

let res = self
.download_file(url.as_ref(), remote_file_path, Some(&hash))
.await;

last_err = res.err();

if last_err.is_none() {
// ready to continue
break;
}
}

if last_err.is_some() {
// SECURITY: should be some.
return Err(last_err.unwrap());
}

let _ = self
Expand Down
Loading