Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add stash account to set in session for relaychain validators #137

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

pepoviola
Copy link
Collaborator

Small refactor to use stash for validatiors in session keys (relaychain). To use the same behavior we have in v1.

@pepoviola pepoviola requested review from wirednkod and l0r1s November 13, 2023 19:33
Copy link

Coverage after merging refact/use_stash into main

77.25%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
crates/configuration/src
   global_settings.rs98.46%100%93.33%99.13%
   hrmp_channel.rs95.88%100%89.47%97.44%
   network.rs99.22%100%97.78%99.36%117, 122, 130, 175, 80, 88
   parachain.rs97.59%100%95.19%97.85%51–53, 551–560, 67–70
   relaychain.rs96.60%100%92.65%97.09%338–347, 77–79
   utils.rs40%100%40%40%11–13, 15–17, 19–21
crates/configuration/src/shared
   errors.rs50%100%50%50%
   helpers.rs100%100%100%100%
   node.rs98.32%100%92.68%98.93%124, 130
   resources.rs96.09%100%94.52%96.43%102, 114, 126–128, 147–150
   types.rs90.40%100%84.16%92.22%279–281, 350–352, 378–379, 381–383, 60–62
crates/orchestrator/src
   errors.rs0%100%0%0%8
   lib.rs0%100%0%0%100–104, 106–109, 111–117, 119, 123, 125–140, 144–167, 171–180, 183, 186–190, 192, 194–198, 201–219, 221–226, 228–249, 253–255, 258, 261–266, 268–271, 274–278, 281, 283, 286–287, 290–294, 296–307, 309–311, 314–318, 320, 322–329, 331–333, 340, 343–367, 372–373, 383, 390–392, 394–403, 405–406, 408–416, 418–425, 427–434, 436–439, 44, 440–447, 45, 450, 46–49, 51–56, 58–64, 66–69, 71, 74, 76–77, 83–90, 93–98
   network.rs0%100%0%0%100–108, 111–117, 119–127, 130–155, 157–168, 171, 173–177, 185–201, 203–205, 208–213, 215–217, 219–221, 223–225, 227–229, 231–233, 235–237, 239–241, 32–40, 43, 56–70, 77–82, 85–94, 96, 98–99
   network_spec.rs93.67%100%83.33%95.52%11, 38
   spawner.rs0%100%0%0%100–108, 110, 113–115, 118–122, 124, 129–134, 136–152, 154–159, 161–177, 19, 42–55, 57–58, 60, 62–65, 69–70, 72, 75–95, 97–99
crates/orchestrator/src/generators
   bootnode_addr.rs97.20%100%100%96.84%
   chain_spec.rs3.27%100%4.84%3.12%100–116, 118–133, 135, 140–153, 156–162, 164–166, 169–197, 199–202, 204–206, 208–221, 223–225, 228–229, 23, 230, 232, 234–246, 248, 251–256, 258–259, 261–274, 276, 279–284, 286–287, 290–303, 305–310, 312–314, 316–318, 321–326, 328–346, 349–358, 361–364, 367, 369–370, 372–387, 389, 39, 391–392, 395–400, 403–421, 428–436, 446–454, 456–468, 47, 470–478, 481–483, 487–490, 492–493, 498–509, 513–526, 528, 531–532, 535–541, 543–548, 554–559, 561, 563, 565–572, 574–577, 580–581, 585–586, 588, 590–591, 593–597, 599–602, 604, 606–607, 609–610, 612–614, 616–618, 620–622, 625–627, 630–634, 636, 638–646, 648–649, 654–661, 663–673, 677–680, 682, 684, 686–692, 694–704, 706–707, 709–729, 731–738, 740, 744–759, 76, 760–764, 766, 77, 775–779, 78, 780–785, 787, 789–799, 80, 800–806, 809, 81, 810–814, 816, 818, 82, 89–92
   command.rs0%100%0%0%100–112, 114–120, 122, 125–130, 132–133, 136–148, 15, 150, 153–155, 157–158, 16, 161–169, 17, 170–179, 18, 180–189, 19, 190–197, 199, 20, 201, 203–209, 21, 210–219, 22, 220–224, 226–229, 23, 231–233, 235–239, 24, 240–243, 246–250, 252–256, 258, 261–269, 271, 274–290, 293–298, 300, 303–305, 307–308, 311–333, 335, 337, 44–62, 64–66, 68–76, 79–97
   errors.rs0%100%0%0%4
   identity.rs82.35%100%60%86.21%13
   key.rs93.75%100%78.57%95.92%36
   keystore.rs0%100%0%0%19–26, 28–31, 34–46, 48–55, 57–64, 66, 68–86
   para_artifact.rs15.94%100%10%16.95%12, 18, 25, 44–46, 48–64, 66–69, 72–81, 83–88, 92–93
   port.rs93.75%100%83.33%96.15%
crates/orchestrator/src/network
   node.rs0%100%0%0%100–103, 106–108, 11, 110, 112–118, 120–122, 124–127, 129–133, 137–145, 25–40, 44–47, 50–52, 55–59, 63–66, 69–72, 79–84, 94–99
   parachain.rs0%100%0%0%100–101, 103–106, 16, 26–34, 36–48, 50–54, 57–61, 64–71, 73, 75, 78–83, 86–87, 89–94, 98–99
   relaychain.rs0%100%0%0%14–21, 5
crates/orchestrator/src/network_helper
   verifier.rs0%100%0%0%10–12, 17, 19–25, 27–32, 34, 8–9
crates/orchestrator/src/network_spec
   node.rs39.17%100%16.67%40.35%108, 146–150, 152–153, 155, 158, 16, 160–163, 165–168, 173–178, 180, 183, 185–215, 217, 90–91, 93–96
   parachain.rs72.04%100%50%73.03%100, 107, 125, 130–133, 136, 147–150, 153, 17, 71–73, 76, 78–80, 86, 95
   relaychain.rs88.71%100%66.67%91.07%100, 17, 70, 93
crates/orchestrator/src/shared
   types.rs26.09%100%11.76%34.48%15, 30, 36, 45–49, 52, 61, 72
crates/prom-metrics-parser/src
   lib.rs91.94%100%80%92.98%103, 125, 53–55, 7, 79
crates/provider/src
   lib.rs50%100%50%50%
crates/provider/src/native
   helpers.rs89.25%100%100%88.37%30–31, 36–38, 59, 90, 94, 98
   namespace.rs88.47%100%85%88.77%109–113, 184, 194–199, 206, 213, 219, 221, 228, 230–231, 245, 310, 317, 322, 327, 332, 339, 352, 422, 430, 456, 461, 465, 485, 489, 524, 531, 547, 585, 589, 74
   node.rs92.27%100%91.45%92.36%1034, 1060, 1130, 116, 1172, 1207, 1218, 1243, 1247–1249, 1252, 1284, 156, 165, 189, 201, 209, 221, 235, 255, 260, 273, 322, 333, 367, 378, 392, 398, 435, 446, 478, 486, 513, 521, 560, 57, 575, 58, 580, 59, 590, 61, 615, 62, 627, 63, 656, 666, 682, 689, 715, 739, 777, 781–783, 786, 812, 848, 85–87, 872, 89–91, 93, 931, 94–95, 970
   provider.rs97.62%100%96.30%97.87%15, 179, 85
crates/provider/src/shared
   types.rs82.96%100%70.27%85.48%124, 141–147, 15–18, 21, 231, 250–257, 80
crates/sdk/src
   lib.rs0%100%0%0%26–30
crates/support/src
   fs.rs75%100%66.67%80%
   net.rs0%100%0%0%10, 4–9
   process.rs100%100%100%100%
crates/support/src/fs
   in_memory.rs95.55%100%96.45%95.37%108, 252, 276, 327, 379, 387, 395, 403, 41–42, 425, 43, 433, 44, 46, 48–51, 53, 548, 570, 58, 598, 615, 633, 640, 659, 686, 703
   local.rs96.23%100%93.98%96.77%63, 8, 89–94
crates/support/src/process
   fake.rs82.47%100%84.62%82.03%126–131, 147, 205, 22, 229–230, 232–249, 302, 319–323, 333, 360, 39–40, 47, 63, 82, 91
   os.rs0%100%0%0%100–102, 16–18, 20–23, 25–27, 29–32, 34–36, 38–40, 43, 47–52, 54–56, 58–60, 62–64, 66–68, 70–71, 76–82, 84–89, 9, 91–95, 97–99
crates/test-runner/src
   lib.rs100%100%100%100%

@pepoviola pepoviola merged commit ef6e6a4 into main Nov 14, 2023
4 checks passed
@pepoviola pepoviola deleted the refact/use_stash branch November 14, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant