-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/k8s provider #130
Feat/k8s provider #130
Conversation
…e, node and helpers) to declutter
…ake code less verbose
…ating namespace/pod, getting log stream and copying file to pod
…me update to trigger start of node manually
…e used in kube client and to verify file integrity (sha/hex)
…reation and custom config map with zombie wrapper script
…r to use default permissions mode
526e2f0
to
89a8732
Compare
…from unit to integration to avoid flakiness
@@ -43,9 +43,14 @@ where | |||
{ | |||
pub(super) async fn new( | |||
namespace: &Weak<KubernetesNamespace<FS>>, | |||
namespace_base_dir: &PathBuf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this field from the weak ref of the namespace?
- Refacto of Native providerf to simplify the logic of cyclic references following emerging design from Kubernetes provider - Removed flaky tests due to mocking of implementation details, tests are in progress to be integrated across the provider/orchestrator/configuration - Removed unused code
Co-authored-by: Loris Moulin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes to make code cleaner and simplify debugging 👍
Coverage after merging feat/k8s-provider into main
Coverage Report
|
This PR introduces the Kubernetes Provider for the SDK, with the use of kube.rs for common operation and a custom file server using axum to transfer files back and forth the nodes.
#35
This also includes the refacto of the native provider to reflect changes to the provider structure with weak references and simplifying the use of abstractions