-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Top level API through zombienet-sdk crate #126
Conversation
Hi @pgherveou, sure ! (and some docs probably) |
@pepoviola most urgent missing bit, apart from this top level package is fixing this todo! that prevent us from defining a custom command. The other thing is:
pub(crate) fn add_para(&mut self, para: Parachain) {
+ para.collators.iter().for_each(|collator| {
+ self.nodes_by_name
+ .insert(collator.name.clone(), collator.clone());
+ });
self.parachains.insert(para.para_id, para);
} |
Coverage after merging pg/add_native into main
Coverage Report
|
Thanks @pgherveou, I just open this #127 to make all the node available through Thx! |
Coverage after merging pg/add_native into main
Coverage Report
|
Not sure I was just trying to get that to run let network = NetworkConfigBuilder::new()
.with_relaychain(|r| {
r.with_chain("rococo-local")
.with_default_command("polkadot")
.with_node(|node| node.with_name("alice"))
.with_node(|node| node.with_name("bob"))
})
.with_parachain(|p| {
p.with_id(100)
.with_default_command("path/to/custom-parachain")
.cumulus_based(true)
.with_collator(|n| n.with_name("collator")
})
.build()
.unwrap()
.spawn_native()
.await?; |
Which para are you using? send me the repo and I can try to reproduce? Thx! |
Coverage after merging pg/add_native into main
Coverage Report
|
Coverage after merging pg/add_native into main
Coverage Report
|
Following up on take 1 #124
Apart from better logs, I realize that one of the only thing missing now for us to start consuming this project is a top level package available (with it's dependencies) on crates.io. This PR serves mainly as a discussion point to get there.
It would be great if we could publish an early version (0.0.1?) on crates.io so that we can start using this asap.