chores: cleanups and todos

[pepoviola]

Small cleanup to looks betters.

[github-actions]

Coverage after merging jv-fixes-clean-up into main

78.05%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
crates/configuration/src
global_settings.rs	98.24%	100%	92.86%	98.99%
hrmp_channel.rs	95.88%	100%	89.47%	97.44%
network.rs	99.34%	100%	97.78%	99.49%	111, 116, 124, 80
parachain.rs	97.59%	100%	95.19%	97.85%	51–53, 551–560, 67–70
relaychain.rs	97.22%	100%	94.03%	97.61%	325–334
utils.rs	100%	100%	100%	100%
crates/configuration/src/shared
errors.rs	50%	100%	50%	50%
helpers.rs	100%	100%	100%	100%
node.rs	98.32%	100%	92.68%	98.93%	124, 130
resources.rs	96.09%	100%	94.52%	96.43%	102, 114, 126–128, 147–150
types.rs	90.29%	100%	84.16%	92.11%	279–281, 350–352, 375–376, 378–380, 60–62
crates/orchestrator/src
errors.rs	0%	100%	0%	0%	8
lib.rs	0%	100%	0%	0%	100–103, 107–110, 112–118, 120, 124, 126–141, 144–169, 173–182, 185, 188–192, 194, 196–200, 203–220, 222–227, 229–238, 241–247, 250, 253–262, 265–269, 272, 274–287, 289–291, 294–298, 300, 302–315, 317–320, 322–324, 335–336, 346, 353–355, 357–366, 368–369, 371–379, 381–388, 390–397, 399, 40, 400–409, 41, 410, 413, 42–45, 47–52, 54–60, 62–65, 71, 73–87, 93–98
network.rs	0%	100%	0%	0%	100–108, 111–117, 119–127, 130–154, 156, 158–167, 170, 172–176, 184–187, 189, 191, 194–199, 201–203, 205–207, 209–211, 213–215, 217–219, 221–223, 225–227, 32–40, 43, 56–70, 77–82, 85–94, 96, 98–99
network_spec.rs	93.67%	100%	83.33%	95.52%	11, 38
spawner.rs	0%	100%	0%	0%	100–103, 105, 109–111, 114–116, 118, 124–144, 146, 148–164, 17, 37–50, 52–53, 55, 57–60, 64–65, 67, 70–90, 92–99
crates/orchestrator/src/generators
bootnode_addr.rs	97.20%	100%	100%	96.84%
chain_spec.rs	3.24%	100%	5%	3.08%	100–111, 113–128, 130, 135–148, 151–157, 159–161, 164–192, 194–197, 199–201, 203–216, 218–219, 22, 220, 223–225, 227, 229–241, 243, 246–251, 253–254, 256–269, 271, 274–279, 281–282, 285–298, 300–305, 307–309, 311–313, 316–321, 323–352, 355, 358–361, 364, 366–367, 369–379, 38, 380–384, 386, 388–389, 392–397, 405–443, 454–459, 46, 460–462, 472–480, 482–494, 496–504, 507–509, 513–516, 518–519, 524–535, 539–552, 554, 557–558, 561–567, 569–574, 580–585, 587, 589, 591–598, 600–603, 606–607, 611–612, 614, 616–617, 619–623, 625–628, 630, 632–633, 635–636, 638–640, 642–644, 646–648, 651–653, 656–660, 662, 664–672, 674–675, 680–687, 689–699, 703–706, 708, 710, 712–717, 719–729, 731–746, 748–749, 75, 750–755, 757, 76, 761–769, 77, 770–781, 783, 792–802, 804, 806–823, 825–829, 831, 833, 84–87, 95–99
command.rs	0%	100%	0%	0%	100–112, 114–120, 122, 125–130, 132–133, 136–148, 15, 150, 153–155, 157–158, 16, 161–169, 17, 170–179, 18, 180–189, 19, 190–197, 199, 20, 201, 203–209, 21, 210–219, 22, 220–224, 226–229, 23, 231–233, 235–239, 24, 240–243, 246–250, 252–256, 258, 261–269, 271, 274–290, 293–298, 300, 303–305, 307–308, 311–333, 335, 337, 44–62, 64–66, 68–76, 79–97
errors.rs	0%	100%	0%	0%	4
identity.rs	82.35%	100%	60%	86.21%	13
key.rs	95.05%	100%	84.62%	96.59%	31
keystore.rs	0%	100%	0%	0%	19–26, 28–31, 34–46, 48–55, 57–64, 66, 68–86
para_artifact.rs	15.94%	100%	10%	16.95%	12, 18, 25, 44–46, 48–64, 66–69, 72–81, 83–88, 92–93
port.rs	93.75%	100%	83.33%	96.15%
crates/orchestrator/src/network
node.rs	0%	100%	0%	0%	10, 100–105, 107–109, 111–114, 116–120, 124–132, 24–39, 43–46, 50–53, 56–59, 66–71, 81–90, 93–95, 97, 99
parachain.rs	0%	100%	0%	0%	15–23, 25–37, 5
relaychain.rs	0%	100%	0%	0%	14–21, 5
crates/orchestrator/src/network_spec
node.rs	39.17%	100%	16.67%	40.35%	108, 146–150, 152–153, 155, 158, 16, 160–163, 165–168, 173–178, 180, 183, 185–215, 217, 90–91, 93–96
parachain.rs	72.04%	100%	50%	73.03%	100, 107, 125, 130–133, 136, 147–150, 153, 17, 71–73, 76, 78–80, 86, 95
relaychain.rs	88.71%	100%	66.67%	91.07%	100, 17, 70, 93
crates/orchestrator/src/shared
types.rs	31.58%	100%	15.38%	40%	13, 28, 34, 43–47, 50
crates/prom-metrics-parser/src
lib.rs	91.94%	100%	80%	92.98%	105, 127, 55–57, 7, 81
crates/provider/src
lib.rs	25%	100%	0%	50%
native.rs	90.47%	100%	81.88%	91.60%	1020, 1024, 1057, 1066, 1087, 1094, 1125, 1152, 1176, 1181, 1209, 1235, 1245, 1252, 1269, 1319, 132, 1377–1378, 1423, 1499–1500, 1524, 155, 1565, 190–194, 262, 281, 294, 296, 303, 305–306, 319, 341, 355–357, 359–361, 363–365, 387–389, 391–393, 41, 434, 454, 49, 503, 552, 581–582, 587–589, 707, 799, 806, 811, 816, 821, 828, 841, 90, 912, 936, 941, 945, 974, 990
crates/provider/src/shared
types.rs	84.47%	100%	74.29%	86.41%	123, 140–146, 15–18, 230, 249–256, 79
crates/support/src
fs.rs	75%	100%	66.67%	80%
net.rs	0%	100%	0%	0%	10, 4–9
crates/support/src/fs
in_memory.rs	95.55%	100%	96.48%	95.37%	149, 271, 321, 372, 424, 432, 440, 448, 470, 478, 593, 615, 643, 660, 678, 685, 704, 731, 748, 79–82, 84, 86–89, 91, 96
local.rs	98.25%	100%	96.30%	98.75%	51, 8
crates/test-runner/src
lib.rs	100%	100%	100%	100%