Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: function() is made private #274

Closed
Daanvdplas opened this issue Nov 15, 2024 · 4 comments · Fixed by #277
Closed

fix: function() is made private #274

Daanvdplas opened this issue Nov 15, 2024 · 4 comments · Fixed by #277

Comments

@Daanvdplas
Copy link

Daanvdplas commented Nov 15, 2024

In the following PR the nodes() function is replaced under the ChainUpgrade trait and made private. There is now no way to obtain this information for external crates.

For parachains it is still possible:

pub fn collators(&self) -> Vec<&NetworkNode> {

@pepoviola
Copy link
Collaborator

Hi @Daanvdplas, thanks for report it. I will make the fn public and craft another release. Sorry about the issue.

Thanks!

@pepoviola
Copy link
Collaborator

Hi @Daanvdplas, can you share how you are using the nodes method in your code to reproduce and fix it.

Thanks!

@Daanvdplas
Copy link
Author

Daanvdplas commented Nov 25, 2024

It is to get the names of the validators and write to the terminal about the nodes in the network, with first the relay nodes and then the parachain nodes. https://github.com/r0gue-io/pop-cli/blob/258a4b2b3b1c8b35a3e39a0f3de4ced808ed316d/crates/pop-cli/src/commands/up/parachain.rs#L121

@Daanvdplas
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants