Update crates/orchestrator/src/network_spec/relaychain.rs

Co-authored-by: Loris Moulin <[email protected]>
paritytech · Sep 27, 2023 · ce91dc5 · ce91dc5
1 parent bc89de2
commit ce91dc5
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/crates/orchestrator/src/network_spec/relaychain.rs b/crates/orchestrator/src/network_spec/relaychain.rs
@@ -89,13 +89,17 @@ impl RelaychainSpec {
         // We want to track the errors for all the nodes and report them ones
         let mut errs: Vec<OrchestratorError> = Default::default();
 
-        let mut nodes: Vec<NodeSpec> = Default::default();
-        config.nodes().iter().for_each(|node_config| {
-            match NodeSpec::from_config(node_config, &chain_context) {
-                Ok(node) => nodes.push(node),
-                Err(err) => errs.push(err),
-            }
-        });
+        let (nodes, errs) = config
+            .nodes()
+            .iter()
+            .map(|node_config| NodeSpec::from_config(node_config, &chain_context))
+            .fold((vec![], vec![]), |(mut nodes, mut errs), result| {
+                match result {
+                    Ok(node) => nodes.push(node),
+                    Err(err) => errs.push(err),
+                }
+                (nodes, errs)
+            });
 
         if !errs.is_empty() {
             // TODO: merge errs