-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update criterion to v0.4.0 #176
Conversation
koushiro
commented
Dec 18, 2022
•
edited
Loading
edited
- update criterion to v0.4.0 (close Update criterion requirement from 0.3.3 to 0.4.0 #165)
- remove some useless dependencies
- close Update env_logger requirement from 0.9 to 0.10 #171
@ordian PTAL |
@@ -14,5 +14,5 @@ hash-db = { path = "../../hash-db" , version = "0.15.2"} | |||
memory-db = { path = "../../memory-db", version = "0.31.0" } | |||
trie-root = { path = "../../trie-root", version = "0.17.0" } | |||
trie-db = { path = "../../trie-db", version = "0.24.0" } | |||
criterion = "0.3.3" | |||
criterion = "0.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ordian could you release a new version of trie-bench
after merging this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koushiro just did publish it, thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup and refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM