Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to codec 2.0 #123

Merged
merged 2 commits into from
Jan 28, 2021
Merged

update to codec 2.0 #123

merged 2 commits into from
Jan 28, 2021

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jan 27, 2021

once it is merge I will publish and add tags

@gui1117
Copy link
Contributor Author

gui1117 commented Jan 27, 2021

wait it actually some crate doesn't compile:

error[E0603]: module `export` is private
   --> /home/thiolliere/.cargo/registry/src/github.com-1ecc6299db9ec823/criterion-0.3.4/src/connection.rs:201:17
    |
201 | #[derive(Debug, Deserialize)]
    |                 ^^^^^^^^^^^ private module
    |
note: the module `export` is defined here
   --> /home/thiolliere/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.123/src/lib.rs:275:5
    |
275 | use self::__private as export;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^

I'll fix it tomorrow, (though substrate chain using this branch is passing CI.)

@ordian ordian merged commit bc7828c into master Jan 28, 2021
@ordian ordian deleted the gui-update-codec-to-2.0 branch January 28, 2021 09:34
@ordian
Copy link
Member

ordian commented Jan 28, 2021

I'll do the publishing shortly.

@ordian
Copy link
Member

ordian commented Jan 28, 2021

Published memory-db, trie-bench, reference-trie. I don't think we need to publish test crates.

@gui1117
Copy link
Contributor Author

gui1117 commented Jan 28, 2021

great thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants