-
Notifications
You must be signed in to change notification settings - Fork 14
feat: use try-runtime-cli instead of command #270
Conversation
Added the |
nice @Moliholy ! thanks for this! quick question: Are the try-runtime sub commands defined in the node still necessary or we can clean them up? https://github.com/paritytech/trappist/blob/main/node/src/command.rs#L390:L472 |
CC: @brunopgalvao |
@hbulgarini to be honest I wasn't totally sure we should remove the command just yet. Nothing in particular, I simply thought to take a conservative approach and leave both ways to run the try-runtime, just in case. Anyhow, let's see what @brunopgalvao says. |
Thanks for your work here @Moliholy
Three options that I see:
I am more in favor of 2. |
b713299
to
209a91c
Compare
Me too. I just added c85650a with the changes. |
209a91c
to
c85650a
Compare
I also added 2d53a48 to remove already applied migrations. Otherwise the migration test won't pass. |
Closes #263.