-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
(cherry picked from commit d826938)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentinfernandez1 This is very difficult to review as-is. Having all PRs mixed up into one means the reviewer has to go back to the original PRs and do a very thorough job of re-examining everything.
My bad, maybe I should have mentioned it in the issue #184.
I would suggest to close it, and restart by opening one separate PR per the original PRs being back-ported. This will be much faster and less error-prone.
In each PR, please specify the original PR number and commit hash e.g.
You are right, I didn't realized how difficult it was going to be to review so many different changes. I will split them into different PRs to simplify it. Also it makes more sense this way since more things will need to be backported like #185 and this way it's going to be easier to identify each change. |
It backports the changes introduced to the main branch and updates them to v9.40. The PRs updated are:
drop_assets
ofTrappistDropAssets
#113asset-registry
refactoring #173The weights of the pallets were re-benchmarked to use Weights V2.
It also fixes Trappist and Stout
UnitWeightCost
to match the config of the parachain-template.