Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Update pallet_uniques string limits. #297

Closed
peterwht opened this issue Sep 29, 2023 · 1 comment
Closed

Update pallet_uniques string limits. #297

peterwht opened this issue Sep 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@peterwht
Copy link
Contributor

Motivation
The current pallet-uniques configuration for StringLimit is too low, at 50 bytes. Users of uniques often store the IPFS CID in the metadata. These CIDs are larger than 50 bytes.

Furthemore, the ValueLimit seems too high at 256 bytes. The value applies to attributes, which would rarely reach 256 bytes.

Suggested Solution

I recommend updating the configuration to use the same as Polkadot's asset hub.
https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/assets/asset-hub-polkadot/src/lib.rs#L683

  • StringLimit = 128
  • KeyLimit = 32
  • ValueLimit = 64
@stiiifff
Copy link
Contributor

stiiifff commented Oct 6, 2023

Closed by #298

@stiiifff stiiifff closed this as completed Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants