-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have a pass over metadata validation #959
Conversation
} | ||
|
||
/// Hash the given metadata. | ||
pub fn hash(&self, metadata: &RuntimeMetadataV15) -> [u8; HASH_LEN] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the per pallet hashing and the global hashing here. The effect is that the per pallet hashing will now also care about any additional details that the global one did (eg runtime APIs).
I think that this is the correct behaviour, but worth a ponder as I might be forgetting something :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
xor
instead ofconcat_and_hash