Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need to import parity-scale-codec to use subxt macro #907

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Remove need to import parity-scale-codec to use subxt macro #907

merged 3 commits into from
Apr 17, 2023

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Apr 12, 2023

Tell the codec derive macro uses where to look for itself in the subxt exports.

ascjones
ascjones approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jsdw jsdw requested a review from a team as a code owner April 14, 2023 11:05
@jsdw jsdw mentioned this pull request Apr 14, 2023
Merged
@niklasad1 niklasad1 merged commit e642740 into master Apr 17, 2023
@niklasad1 niklasad1 deleted the jsdw-codec-crate-path branch April 17, 2023 07:13
@jsdw jsdw mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsdw @ascjones @niklasad1