Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make signing fallable and asynchronous #119

Merged
merged 4 commits into from
May 29, 2020
Merged

Make signing fallable and asynchronous #119

merged 4 commits into from
May 29, 2020

Commits on May 28, 2020

  1. Make signing fallable and asynchronous 

    This is needed for hardware wallets, which require human confirmation to
sign transactions.  Blocking on a human to sign transactions is not a
good idea, and the signing might fail for many reasons (device
unplugged, authorization not granted, etc).
    @Demi-Marie
    Demi-Marie committed May 28, 2020
    Configuration menu
    Copy the full SHA
    193104c View commit details
    Browse the repository at this point in the history

  2. Reformat

    @Demi-Marie
    Demi-Marie committed May 28, 2020
    Configuration menu
    Copy the full SHA
    36b124d View commit details
    Browse the repository at this point in the history

  3. Refactor as suggested by Andrew Jones (@ascjones).

    @Demi-Marie
    Demi-Marie committed May 28, 2020
    Configuration menu
    Copy the full SHA
    bc19991 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Use future::ok

    @ascjones
    ascjones committed May 29, 2020
    Configuration menu
    Copy the full SHA
    e196153 View commit details
    Browse the repository at this point in the history