Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Simple Trait to Inspect Metadata #9893

Merged
2 commits merged into from
Sep 30, 2021
Merged

Simple Trait to Inspect Metadata #9893

2 commits merged into from
Sep 30, 2021

Conversation

shawntabrizi
Copy link
Member

This introduces a very simple trait to inspect the metadata of an asset.

Closes: #9877

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 29, 2021
@KiChjang
Copy link
Contributor

I'm not sure if creating a new trait is the best solution for this. We could add a pallet::getter for the Metadata storage item, and then implement accessors on the AssetsMetadata struct.

Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind a getter and accessor but I feel like the trait fits well in the current traits for fungibles

@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Sep 30, 2021

Trying merge.

@ghost ghost merged commit bf9683e into master Sep 30, 2021
@ghost ghost deleted the shawntabrizi-inspect-metadata branch September 30, 2021 16:46
ordian added a commit that referenced this pull request Oct 2, 2021
* master: (67 commits)
  Downstream `node-template` pull (#9915)
  Implement core::fmt::Debug for BoundedVec (#9914)
  Quickly skip invalid transactions during block authorship. (#9789)
  Add SS58 prefix for Automata (#9805)
  Clean up sc-peerset (#9806)
  Test each benchmark case in own #[test] (#9860)
  Add build with docker section to README (#9792)
  Simple Trait to Inspect Metadata (#9893)
  Pallet Assets: Create new asset classes from genesis config (#9742)
  doc: subkey usage (#9905)
  Silence alert about large-statement-fetcher (#9882)
  Fix democracy on-initialize weight (#9890)
  Fix basic authorship flaky test (#9906)
  contracts: Add event field names (#9896)
  subkey readme update on install (#9900)
  add feature wasmtime-jitdump (#9871)
  Return `target_hash` for finality_target instead of an Option (#9867)
  Update wasmtime to 0.29.0 (#9552)
  Less sleeps (#9848)
  remove unidiomatic (#9895)
  ...
niklasad1 added a commit that referenced this pull request Oct 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata in pallet-assets cannot be accessed by other pallet
4 participants