Fix WrapperOpaque max encded len and type info #9881
Conversation
gui1117
added
A0-please_review
|
@ascjones maybe you can review this one ? I forgot to declare the correct type info of the type |
gui1117
added
C3-medium
gui1117
added
B0-silent
frame/support/src/traits/misc.rs
Outdated
| // Note: this can be improved if `T::max_encoded_len` is small. | ||
| // E.g. if T max encoded len is 4, then the compact encoding of its encoded length is 1. |
There was a problem hiding this comment.
Why this comment here?
The point of this is to return the max encoded length?
There was a problem hiding this comment.
yes but I think we can be more precise in certain situation, I finally did the more precise implementation 5f07186
|
bot merge |
|
Trying merge. |
ghost
merged commit
|
ah sorry I didn't see you asked review of ascjones, I'll ping him and ensure he get to see it |
| .type_params(vec![TypeParameter::new("T", Some(meta_type::<T>()))]) | ||
| .composite( | ||
| Fields::unnamed() | ||
| .field(|f| f.compact::<u32>().type_name("EncodedLengthOfT")) |
There was a problem hiding this comment.
We don't need type_name here. It is optional and is used for the name of the type of the field as it appears in the code, in order to identify alias usage. E.g. where the concrete type is u128 the type_name would be Balance for example.
There was a problem hiding this comment.
I see, I'll do another PR with this removed
No description provided.