Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Check all project dependents instead of just Polkadot #9749

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Check all project dependents instead of just Polkadot #9749

merged 1 commit into from
Oct 14, 2021

Conversation

joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented Sep 10, 2021 •
edited
Loading

❗ This PR is marked as Draft in order to prevent accidental merges. The merge should be performed by someone with access to the Github Repository Settings. Do not merge before renaming the required statuses on the settings, otherwise future PRs will get stuck.

  • continuous-integration/gitlab-check-polkadot-companion-build was renamed to continuous-integration/gitlab-check-dependent-polkadot
  • continuous-integration/gitlab-check-polkadot-companion-status is deleted (now it's part of continuous-integration/gitlab-check-dependent-polkadot)
  • continuous-integration/gitlab-check-dependent-cumulus was added

closes https://github.com/paritytech/ci_cd/issues/139
supersedes #9010

For more context see https://github.com/paritytech/ci_cd/issues/227

@joao-paulo-parity joao-paulo-parity self-assigned this Sep 10, 2021
@joao-paulo-parity joao-paulo-parity requested a review from a team as a code owner September 10, 2021 13:17
@joao-paulo-parity joao-paulo-parity mentioned this pull request Sep 10, 2021
Closed
joao-paulo-parity
joao-paulo-parity commented Sep 10, 2021
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
@joao-paulo-parity joao-paulo-parity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 10, 2021
@joao-paulo-parity joao-paulo-parity force-pushed the jp/companions branch 5 times, most recently from 93bd47c to a1c8d5d Compare September 13, 2021 07:19
@joao-paulo-parity joao-paulo-parity changed the title [WIP] Check all project dependents instead of just Polkadot [BLOCKED] Check all project dependents instead of just Polkadot Sep 13, 2021
@TriplEight
Copy link
Contributor

cc #9721 (comment)

TriplEight
TriplEight suggested changes Sep 13, 2021
View reviewed changes
.maintain/gitlab/check_dependent_project.sh Outdated Show resolved Hide resolved
.maintain/gitlab/check_dependent_project.sh Outdated Show resolved Hide resolved
@TriplEight
Copy link
Contributor

FYI: https://github.com/paritytech/ci_cd/issues/178#issuecomment-920963990

@TriplEight TriplEight self-requested a review September 17, 2021 12:49
@joao-paulo-parity joao-paulo-parity mentioned this pull request Sep 20, 2021
Closed
@joao-paulo-parity joao-paulo-parity changed the title [BLOCKED] Check all project dependents instead of just Polkadot Check all project dependents instead of just Polkadot Sep 24, 2021
@joao-paulo-parity
Copy link
Contributor Author

This is no longer blocked but it seems like two dependent projects are breaking:

Do I create companions for those or do we have to modify the Substrate code for them?

@joao-paulo-parity
Copy link
Contributor Author

joao-paulo-parity commented Sep 24, 2021 •
edited
Loading

Update: grandpa-bridge-gadget was merged into Substrate, therefore the dependency is no longer necessary and I've removed its check. Now we're only expecting the cumulus integration to fail.

@joao-paulo-parity joao-paulo-parity requested a review from a team September 24, 2021 17:33
@TriplEight
Copy link
Contributor

FYI we've rolled back the CI image to debian 10 and it will take some time to prepare for this upgrade properly. It makes sense to install the newer version of jq directly to the image

@joao-paulo-parity
Copy link
Contributor Author

joao-paulo-parity commented Sep 28, 2021 •
edited
Loading

I'll open a PR for https://github.com/paritytech/scripts/blob/master/dockerfiles/ci-linux/Dockerfile. Until it's put into effect, this is blocked.

@joao-paulo-parity joao-paulo-parity changed the title Check all project dependents instead of just Polkadot [BLOCKED] Check all project dependents instead of just Polkadot Sep 28, 2021
@joao-paulo-parity joao-paulo-parity mentioned this pull request Sep 28, 2021
Merged
@joao-paulo-parity
Copy link
Contributor Author

I'll open a PR for https://github.com/paritytech/scripts/blob/master/dockerfiles/ci-linux/Dockerfile. Until it's put into effect, this is blocked.

The PR was merged and so this branch is unblocked again

@joao-paulo-parity joao-paulo-parity changed the title [BLOCKED] Check all project dependents instead of just Polkadot Check all project dependents instead of just Polkadot Oct 1, 2021
@joao-paulo-parity joao-paulo-parity mentioned this pull request Oct 1, 2021
Closed
@joao-paulo-parity
Copy link
Contributor Author

paritytech/polkadot#3981 helps the cumulus check failure but it's not enough to make the check pass (paritytech/cumulus#634)

@joao-paulo-parity joao-paulo-parity mentioned this pull request Oct 1, 2021
Closed
@joao-paulo-parity joao-paulo-parity marked this pull request as draft October 1, 2021 13:25
@joao-paulo-parity
Copy link
Contributor Author

joao-paulo-parity commented Oct 1, 2021 •
edited
Loading

The implementation is ready and statuses are passing but I've moved it to Draft so that it will not be merged by accident. @TriplEight or someone else with Repository Settings access are the ones who should merge this PR so they'll be able to rename the required statuses according to the description.

@joao-paulo-parity joao-paulo-parity mentioned this pull request Oct 1, 2021
Closed
@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review October 5, 2021 14:22
@joao-paulo-parity joao-paulo-parity marked this pull request as draft October 5, 2021 14:38
@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review October 5, 2021 23:40
@joao-paulo-parity joao-paulo-parity marked this pull request as draft October 5, 2021 23:40
@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review October 5, 2021 23:47
@joao-paulo-parity joao-paulo-parity marked this pull request as draft October 5, 2021 23:49
@rcny
Copy link
Contributor

rcny commented Oct 13, 2021

LGTM

@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review October 14, 2021 03:05
@joao-paulo-parity joao-paulo-parity mentioned this pull request Oct 14, 2021
Closed
@joao-paulo-parity joao-paulo-parity force-pushed the jp/companions branch 2 times, most recently from 1817de4 to c69ca9a Compare October 14, 2021 12:15
TriplEight
TriplEight suggested changes Oct 14, 2021
View reviewed changes
.gitlab-ci.yml Outdated
Comment on lines 549 to 551
--depth=1
"--branch=$PIPELINE_SCRIPTS_TAG"
https://github.com/paritytech/pipeline-scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--depth=1
"--branch=$PIPELINE_SCRIPTS_TAG"
https://github.com/paritytech/pipeline-scripts
--depth=1
"--branch=$PIPELINE_SCRIPTS_TAG"
https://github.com/paritytech/pipeline-scripts

@TriplEight TriplEight merged commit f87ea7d into master Oct 14, 2021
@TriplEight TriplEight deleted the jp/companions branch October 14, 2021 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcny rcny rcny approved these changes

@TriplEight TriplEight TriplEight approved these changes

@s3krit s3krit Awaiting requested review from s3krit

Assignees

@joao-paulo-parity joao-paulo-parity

Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joao-paulo-parity @TriplEight @rcny