This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
add query types to generate_storage_alias #9659
Merged
Merged
+60
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Sep 1, 2021
apopiak
added
A0-please_review
Pull request needs code review.
B3-apinoteworthy
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Sep 7, 2021
kianenigma
approved these changes
Sep 7, 2021
jflatow
approved these changes
Sep 7, 2021
shawntabrizi
approved these changes
Sep 7, 2021
What's the unleash check about? |
bot merge |
Trying merge. |
ghost
deleted the
apopiak/storage-alias-query-types
branch
September 8, 2021 08:48
should be ignored for now. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying the
QueryKind
to thegenerate_storage_alias
macro.It can be specified as the last type parameter like so:
Changes the default
QueryKind
forValue
storage aliases with a generic type (like in the example above) to the default of the underlying type, which isOptionQuery
(the macro used to hard-codeValueQuery
before).