Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add query types to generate_storage_alias #9659

Merged
8 commits merged into from
Sep 8, 2021

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Aug 31, 2021

This PR adds support for specifying the QueryKind to the generate_storage_alias macro.
It can be specified as the last type parameter like so:

generate_storage_alias!(Prefix, ValueName<T: Config> => Value<T::Balance, ValueQuery>);

⚠️ Breaking Change:

Changes the default QueryKind for Value storage aliases with a generic type (like in the example above) to the default of the underlying type, which is OptionQuery (the macro used to hard-code ValueQuery before).

@apopiak apopiak added the A3-in_progress Pull request is in progress. No review needed at this stage. label Sep 1, 2021
@apopiak apopiak added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Sep 7, 2021
@apopiak apopiak marked this pull request as ready for review September 7, 2021 08:45
@apopiak
Copy link
Contributor Author

apopiak commented Sep 8, 2021

What's the unleash check about?

@apopiak
Copy link
Contributor Author

apopiak commented Sep 8, 2021

bot merge

@ghost
Copy link

ghost commented Sep 8, 2021

Trying merge.

@ghost ghost merged commit 89cd02d into master Sep 8, 2021
@ghost ghost deleted the apopiak/storage-alias-query-types branch September 8, 2021 08:48
@kianenigma
Copy link
Contributor

What's the unleash check about?

should be ignored for now.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants