This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
pallet-staking: Reorg migration, pallet and pallet impls #9410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kianenigma I am thinking for now we can just move the migrations module. And then once the bags PR becomes very stable we can do a bigger re-org. My concern with doing a big re-org now is that transferring those changes to the bags PR would be difficult and may result in us losing some details without realizing. |
|
I am fine with both. The bags PR has a small footpring in the rest of the pallet, so I think it is possible to do the full move as well. Nonetheless, this is not worth risking anything. We can always do this later. |
emostov
changed the title
emostov
added
A0-please_review
kianenigma
reviewed
Jul 27, 2021
kianenigma
reviewed
Jul 27, 2021
frame/staking/src/lib.rs
Outdated
| @@ -3415,6 +880,16 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// A `Convert` implementation that finds the stash of the given controller account, | |||
| /// if any. | |||
| pub struct StashOf<T>(sp_std::marker::PhantomData<T>); | |||
There was a problem hiding this comment.
Yeah I was thinking something like that for a follow up
kianenigma
approved these changes
Jul 27, 2021
emostov
changed the title
shawntabrizi
approved these changes
Jul 27, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
6 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9408
The main thing left out of this is moving the storage items and types to their own module (they are left in lib.rs for now). I think that should be easy to do in a follow up PR and leaving it out now will make it slightly easier to merge this change into other open PRs that touch staking.
Note, the visibility on few functions in
impl.rswas increased from either private orpub(super)topub(crate).cc @kianenigma