-
Notifications
You must be signed in to change notification settings - Fork 2.6k
pallet-collective: Do not vote aye
with propose
#9323
Conversation
IMO yes, this should be the behavior, plus it wont break the transaction versioning as this PR does. |
aye
with propose
aye
with propose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a retract_vote
would also be nice in general.
to be very pedantic, since the underlying behaviour of a transaction is changing, that's still a transaction version change. I know that we mostly use transaction version for instances where a parameter is added or removed, but that's not exactly true. |
Do we have a definition for transaction version somewhere? AFAICT we use to signify a broken call index or broken call signature so wallets can get a heads up. But I have not seen it used for a logic change (although I think we should have some versioning reflect breaking changes to logic.)
I see merit for this, but seems counter to the intentions of the voting system design because it arguably encourages passive behavior and reliance on the prime member. You can always flip your vote between aye & nay. |
Sorry I disagree here. This is a runtime upgrade and a |
/benchmark runtime pallet pallet_treasury |
Benchmark Runtime Pallet for branch "zeke-retract-vote" with command cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
… zeke-retract-vote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. need to let benchmarks finish.
cc @rrtti
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs
Benchmark Runtime Pallet for branch "zeke-retract-vote" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs
/benchmark runtime pallet pallet_collective |
Benchmark Runtime Pallet for branch "zeke-retract-vote" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/collective/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/collective/src/weights.rs --template=./.maintain/frame-weight-template.hbs
…strate into zeke-retract-vote
/benchmark runtime pallet pallet_collective |
…/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_collective --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/collective/src/weights.rs --template=./.maintain/frame-weight-template.hbs
/benchmark runtime pallet pallet_treasury |
Finished benchmark for branch: zeke-retract-vote Benchmark: Benchmark Runtime Pallet cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs ResultsPallet: "pallet_treasury", Extrinsic: "propose_spend", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
|
…/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs
bot merge |
Waiting for commit status. |
@emostov Hello, Ask a question, is there any way to know whether the chain has updated this pr, subscan when propose is created, vote aye+1 by default |
@freehere107 It is not on Polkadot or Kusama yet - it will be though once they update to runtime v9090 or above. For something like this it should get listed in the release notes. I checked and its in v0.9.9 (see the notes here https://github.com/paritytech/polkadot/releases/tag/v0.9.9); which corresponds to runtime v9090 for polkadot & kusama. To figure out the current runtime you can query the |
For polkadot, kusama, this can be accurate to the spec version. But for other networks, we are not sure when they will merge this pr. I think this break change should be more convenient to add storage like the previous |
@freehere107 you should be able to query the aye / nay from the storage directly rather than making this assumption. |
@shawntabrizi Yes, thank you for reminding me, votes can get from chain storage |
Closes #6558
This is a breaking change for the
propose
extrinsic behavior.Currently, when executing
propose
, the caller records anaye
vote for the proposal. This PR removes that logic so no votes are recorded whenpropose
executes.