-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
thank you! cc @jacogr |
@@ -34,6 +34,7 @@ pub trait ChildStateApi<Hash> { | |||
/// RPC Metadata | |||
type Metadata; | |||
|
|||
/// DEPRECATED: Please use `childstate_getKeysPaged` with proper paging support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not actually mark this as deprecated somewhere?
What is the process to eventually get rid of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really sure. This is just text that will show in rust doc, I copy pasted it from its top storage counterpart.
Maybe there is a better way or could be interesting to remove in a next version with other impacting rpc changes
(I thing the comment for the state
function was here for rather long).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some doc improvements
Co-authored-by: Alexander Popiak <[email protected]>
Co-authored-by: Alexander Popiak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Dunno about the deprecated thing though. Feels we should clean it up
I like the fact that this PR does not break anything, I think I will open a different one removing the deprecated api. |
bot merge |
Trying merge. |
Paged rpc
childstate_getKeysPaged
for child storage on the same model asstate_getKeysPaged
.closes #9086.
polkadot companion: paritytech/polkadot#3258