Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix initial era in staking #8984

Closed
wants to merge 1 commit into from
Closed

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jun 1, 2021

Fix #8911

Breaking change

The election for the initial era must be successful to create the initial era.
In the past a failing initial election would generate an initial era with no stakers
Now a failing initial election will generate no initial era.

Done

  • refactor test in order not to use this initial era created from failing election.

To do

  • look at pallet session if no initial era can result in unexpected logic.

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jun 1, 2021
Base automatically changed from kiz-genesis-election-provider to gui-improve-staking-no-election June 3, 2021 19:16
Base automatically changed from gui-improve-staking-no-election to master June 14, 2021 14:02
@stale
Copy link

stale bot commented Jul 14, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 14, 2021
@stale stale bot closed this Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve pallet-session/pallet-staking for computation of initial era
1 participant