This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove native execution, grow heap as needed #8893
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
B0-silent
Changes should not be mentioned in any release notes
C7-high ❗️
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
and removed
A0-please_review
Pull request needs code review.
labels
May 24, 2021
gavofyork
changed the title
Grow heap to a maximum if needed
Remove native execution, grow heap as needed
May 24, 2021
0x7CFE
reviewed
May 25, 2021
pepyakin
reviewed
May 25, 2021
This closes #7288? |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Jul 7, 2021
louismerlin
removed
the
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
label
Oct 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A3-in_progress
Pull request is in progress. No review needed at this stage.
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
B0-silent
Changes should not be mentioned in any release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
This essentially avoids the memory requirement issue by assuming that runtimes are probably not going to try to run the node out of memory (a pre-existing assumption of native execution mode, so no worse than at present).
It may be reasonable to constrain the heap pages to a different maximum (i.e. not 3 GB) in the case of running untrusted (i.e. PVF) code.
It removes the direct native call execution. It currently keeps the indirect (encoded/decoded) native call execution.
TODO:
Closes #7288