-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Migrate pallet-session and session-historical to pallet attribute macro #8815
Migrate pallet-session and session-historical to pallet attribute macro #8815
Conversation
@stanly-johnson Please use tabs in the modified files per our coding standards. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration looks good, but I can still see spaces with some of these files.
|
} | ||
|
||
decl_storage! { | ||
trait Store for Module<T: Config> as Session { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. The historical pallet will no longer use the Session
storage.
This needs a storage migration.
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Still needs a storage migration |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Part of #7882.
Converts the
session
andsession-historical
pallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.