Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-tips | port to frame v2 #8205

Closed

Conversation

shamb0
Copy link
Contributor

@shamb0 shamb0 commented Feb 25, 2021

pallet-tips | port to frame v2

related #7882 | Has dependency on #8196 , #8193

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: 
Thus any use of this pallet in construct_runtime! should be careful to update name 
in order not to break storage or to upgrade storage (moreover for instantiable pallet). 
If pallet is published, make sure to warn about this breaking change.

So users of the treasury pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the treasury pallet.

@gui1117
Copy link
Contributor

gui1117 commented Mar 25, 2021

is it ready to review ?
I think it will need a specific migration code in order to move the items away from Treasury into the correct pallet prefix.

@shamb0 shamb0 marked this pull request as ready for review March 25, 2021 14:12
@gui1117 gui1117 added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 25, 2021
@shamb0
Copy link
Contributor Author

shamb0 commented Mar 29, 2021

Hello @thiolliere, Please consider this PR inhold, This PR has dependency on PR #8196, bit facing some challenges in rebasing it.
Will pick it up once #8196 is merged.

@shawntabrizi
Copy link
Member

closing because stale

if you want to update, feel free to reopen.

@shamb0
Copy link
Contributor Author

shamb0 commented May 3, 2021

Sure @shawntabrizi , will reopen after merging with latest master 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants