This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
additional doc on repatriate_reserved #8135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A0-please_review
|
Making it even more explicit is good, but the problem of paritytech/polkadot-sdk#337 still persists, awaiting more inputs. substrate/frame/support/src/traits.rs Line 1158 in 5e8df39 |
|
I missunderstood the original issue, so I close it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related paritytech/polkadot-sdk#337
repatriate_reserved is failing if beneficiary is not an existing account, thus better to make it explicit in the doc.
Otherwise we can also make repatriate_reserved allowing to repatriate to unexisting account but this is changing the current logic.