Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix telemetry span not entering properly & enter span in sc-cli #7951

Merged
20 commits merged into from
Jan 29, 2021
Merged

Fix telemetry span not entering properly & enter span in sc-cli #7951

20 commits merged into from
Jan 29, 2021

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Jan 21, 2021 •
edited
Loading

The span was not entering for all the background tasks properly.

Related to paritytech/cumulus#301 (comment)

Polkadot companion: paritytech/polkadot#2336

@cecton cecton added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 21, 2021
@cecton cecton requested a review from bkchr January 21, 2021 18:19
dvdplm
dvdplm suggested changes Jan 22, 2021
View reviewed changes
client/service/src/builder.rs Outdated Show resolved Hide resolved
client/service/src/builder.rs Outdated Show resolved Hide resolved
client/service/src/task_manager/mod.rs Outdated Show resolved Hide resolved
@cecton cecton marked this pull request as draft January 22, 2021 19:24
@cecton cecton marked this pull request as ready for review January 22, 2021 20:04
@cecton cecton changed the title Fix telemetry span not entering properly Fix telemetry span not entering properly & enter span in sc-cli Jan 22, 2021
@cecton
Copy link
Contributor Author

cecton commented Jan 22, 2021

Voila, now I think it's perfect 👌 I wish I would have thought of that earlier 😁

Review requested

dvdplm
dvdplm approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/service/src/task_manager/mod.rs Outdated Show resolved Hide resolved
@cecton
Copy link
Contributor Author

cecton commented Jan 29, 2021

@bkchr can you approve the polkadot PR? paritytech/polkadot#2336

@cecton
Copy link
Contributor Author

cecton commented Jan 29, 2021

bot merge

@ghost
Copy link

ghost commented Jan 29, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Jan 29, 2021

Merge failed: "Required status check \"continuous-integration/gitlab-check-labels\" is pending."

@cecton
Copy link
Contributor Author

cecton commented Jan 29, 2021

bot merge

@ghost
Copy link

ghost commented Jan 29, 2021

Trying merge.

@ghost ghost merged commit 1d5d13a into master Jan 29, 2021
@ghost ghost deleted the cecton-fix-telemetry-span-not-entering-properly branch January 29, 2021 12:03
@cecton cecton mentioned this pull request Jan 29, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecton @dvdplm @bkchr