This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make consensus SlotWorker don't assume a slot is time / duration
#7441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the last bit of assumption that a slot is always `time / duration`. This will be required by parachains where a slot will be the relay chain block number. Besides this there are also some other drive by changes. One more notable is that `on_slot` now returns a `SlotResult` that holds the block and a potential storage proof. To simplify the implementation and usage of the `SimpleSlotWorker` the `SlotWorker` trait is now implemented for each type that implements `SimpleSlotWorker`.
bkchr
added
A0-please_review
|
Contributes towards: paritytech/cumulus#216 |
andresilva
approved these changes
Oct 27, 2020
| @@ -37,30 +37,6 @@ pub fn duration_now() -> Duration { | |||
| )) | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think this was added in order to be used with BABE's relative time protocol, but since that wasn't implemented we might as well remove this for now anyway.
Co-authored-by: André Silva <[email protected]>
Co-authored-by: André Silva <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last bit of assumption that a slot is always
time / duration. This will be required by parachains where a slot will be therelay chain block number. Besides this there are also some other drive
by changes. One more notable is that
on_slotnow returns aSlotResultthat holds the block and a potential storage proof.To simplify the implementation and usage of the
SimpleSlotWorkertheSlotWorkertrait is now implemented for each type that implementsSimpleSlotWorker.