This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix vanity command by taking the network into account #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A0-please_review
kianenigma
reviewed
Sep 23, 2020
kianenigma
reviewed
Sep 23, 2020
kianenigma
reviewed
Sep 23, 2020
client/cli/src/commands/vanity.rs
Outdated
| @@ -171,7 +178,7 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_generation_with_single_char() { | |||
| let seed = generate_key::<sr25519::Pair>("j").unwrap(); | |||
| let seed = generate_key::<sr25519::Pair>("j", Default::default()).unwrap(); | |||
There was a problem hiding this comment.
This test case should also be a bit more meaningful or removed? Default is basically Substrate and testing for just j to be there seems a bit flaky.
There was a problem hiding this comment.
I also changed it to ab. In the end it isn't such a great test. But this test is random and we don't want to wait until the end of the universe for a result :D
kianenigma
approved these changes
Sep 23, 2020
Co-authored-by: Kian Paimani <[email protected]>
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
bot merge |
|
The PR is currently unmergeable. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7177