Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Do not panic while panicking #7167

Merged
3 commits merged into from
Sep 22, 2020
Merged

Do not panic while panicking #7167

3 commits merged into from
Sep 22, 2020

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Sep 21, 2020

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 21, 2020
@bkchr bkchr requested a review from NikVolf September 21, 2020 22:36
dvdplm
dvdplm approved these changes Sep 22, 2020
View reviewed changes
primitives/runtime/src/lib.rs Outdated Show resolved Hide resolved
cheme
cheme approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bkchr
Copy link
Member Author

bkchr commented Sep 22, 2020

bot merge

@ghost
Copy link

ghost commented Sep 22, 2020

Waiting for commit status.

@ghost ghost merged commit 07f480b into master Sep 22, 2020
@ghost ghost deleted the bkchr-dont-panic-in-panic branch September 22, 2020 07:36
@pepyakin pepyakin mentioned this pull request Oct 9, 2020
Open
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NikVolf NikVolf NikVolf approved these changes

@dvdplm dvdplm dvdplm approved these changes

@cheme cheme cheme approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @dvdplm @cheme @NikVolf