Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Forward-port BFT fixes from v0.2 and restructure agreement cancelling #619

Merged
merged 5 commits into from
Aug 28, 2018

Conversation

rphmeier
Copy link
Contributor

Closes #605 .

The only new commit is 6c6cae1 which will need to be backported to v0.2. All the others are cherry-picks from v0.2.

@rphmeier rphmeier added the A0-please_review Pull request needs code review. label Aug 28, 2018
@rphmeier rphmeier requested review from gavofyork and arkpar August 28, 2018 10:38
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavofyork gavofyork merged commit 06519fb into master Aug 28, 2018
@gavofyork gavofyork deleted the rh-better-bft-cancel branch August 28, 2018 11:28
@gavofyork gavofyork restored the rh-better-bft-cancel branch August 28, 2018 11:29
@gavofyork gavofyork deleted the rh-better-bft-cancel branch August 28, 2018 11:29
dvdplm added a commit that referenced this pull request Aug 29, 2018
* master:
  Contracts: Per block gas limit (#506)
  Make sure to ban invalid transactions. (#615) (#620)
  Forward-port BFT fixes from v0.2 and restructure agreement cancelling (#619)
  Allow specifying listening multiaddresses (#577)
  Introduce Runtime Events (#607)
  update substrate/extrinsic-pool (#616)
  add a new unit test for extrinsic pool (#611)
  set the current repo in Cargo.toml (#610)
  add cli for purge chain (#609)
dvdplm added a commit that referenced this pull request Sep 3, 2018
…rs-generic-over-hasher-and-rlpcodec

* origin/master: (26 commits)
  Contract runtime polishing (#601)
  WIP on chain heap (#639)
  Events to track extrinsic success (#640)
  Install llvm-tools-preview component (#643)
  fix wasm executor compile error (#631)
  random fixes (#638)
  Empty becomes (), reflecting convention (#637)
  Allow to build_upon skipped entries, but don't walk back (#635)
  Separate out staking module into balances and payment (#629)
  Update .gitlab-ci.yml (#633)
  Do not attempt to rustup if in CI. This is taken care of by the base (#621)
  Avoid need for ident strings in storage (#624)
  rename to panic_handler as panic_implementation is deprecated in nightly (#626)
  5 random fixes (#2) (#623)
  fix one typo in README (#627)
  Misspelled words (#625)
  Contracts: Per block gas limit (#506)
  Make sure to ban invalid transactions. (#615) (#620)
  Forward-port BFT fixes from v0.2 and restructure agreement cancelling (#619)
  Allow specifying listening multiaddresses (#577)
  ...
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* split minimal_withdrawal and required fee 

fix https://github.com/chainpool/ChainX/issues/610
support a rpc for this feature

* fix bug for withdrawal list 

fix bug https://github.com/chainpool/ChainX/issues/609
when no txid, it's Broadcasting

* support application state for withdrawal_list rpc

support for https://github.com/chainpool/ChainX/issues/614
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants