This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Apr 25, 2020
shawntabrizi
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Apr 25, 2020
athei
suggested changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to request changes as the refund API is not used correctly.
athei
reviewed
Apr 27, 2020
@athei updated, let me know if anything else stands out to you |
athei
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
Pull request needs code review.
labels
Apr 28, 2020
bot merge |
Cannot merge; please ensure the pull request is mergeable and has approval from the project owner or at least 2 core devs. |
bot merge cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final weights for the Utility pallet using benchmarking data.
In this case, the Weight of the
call
functions or the number of signatories in the vector can be out of our control, so we use saturating math everywhere.