Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update Weights for Utility Pallet #5787

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Apr 25, 2020

Final weights for the Utility pallet using benchmarking data.

In this case, the Weight of the call functions or the number of signatories in the vector can be out of our control, so we use saturating math everywhere.

@shawntabrizi shawntabrizi added the A3-in_progress Pull request is in progress. No review needed at this stage. label Apr 25, 2020
@shawntabrizi shawntabrizi added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 25, 2020
@shawntabrizi shawntabrizi added this to the 2.0 milestone Apr 25, 2020
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to request changes as the refund API is not used correctly.

frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
frame/utility/src/lib.rs Outdated Show resolved Hide resolved
@shawntabrizi shawntabrizi requested a review from athei April 28, 2020 16:07
@shawntabrizi
Copy link
Member Author

@athei updated, let me know if anything else stands out to you

Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shawntabrizi shawntabrizi added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Apr 28, 2020
@gnunicorn
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Apr 29, 2020

Cannot merge; please ensure the pull request is mergeable and has approval from the project owner or at least 2 core devs.

@ghost
Copy link

ghost commented Apr 29, 2020

bot merge cancel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants