This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Attempt to make Client generic over Hasher/NodeCodec
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hits a problem when calling `with_externalities` as the `Externalities` cannot be generic due to the limitations of `environmental`. Can this be solved?
dvdplm
added
A1-onice
I4-annoyance
|
i don't think it can be "solved" as such, but i'm not sure it really needs to be. the externalities should only provide static, fixed functionality - afaik both types and semantics that |
gavofyork
added
A3-in_progress
|
Ok, yeah, I tinkered further with it and reached pretty much the same conclusion, thanks for the feedback. Closing. |
Merged
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Bump Substrate. * Bump version
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Place the deprecated modules * Use regenesis_params * Imple regenesis builder * Try loading the regenesis data * Commit regenesis data * Fix format * Use 3696796 * Delete unused file * Remove deprecated_builder * Nits
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Bump versions to `v0.22.0` Signed-off-by: Alexandru Vasile <[email protected]> * Add missing crates for releasing chore Signed-off-by: Alexandru Vasile <[email protected]> * Update changelog Signed-off-by: Alexandru Vasile <[email protected]> * Update changelog message & remove non-user facing PRs Signed-off-by: Alexandru Vasile <[email protected]> * Update CHANGELOG.md Co-authored-by: James Wilson <[email protected]> * Update CHANGELOG.md Co-authored-by: James Wilson <[email protected]> Co-authored-by: James Wilson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more of a question/illustration of a problem I've had on previous PRs. The attempt to make
Clientgeneric overHasher/NodeCodechits a problem when callingruntime_io::with_externalities(example callsite) as theExternalitiescannot be generic due to the limitations ofenvironmental. Can this be solved somehow?