This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Repair and extend some benchmarks #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
the
A3-in_progress
shawntabrizi
added
A0-please_review
kianenigma
reviewed
Apr 20, 2020
| @@ -65,7 +65,7 @@ pub trait Trait<I: Instance=DefaultInstance>: frame_system::Trait { | |||
| type Origin: From<RawOrigin<Self::AccountId, I>>; | |||
|
|
|||
| /// The outer call dispatch type. | |||
| type Proposal: Parameter + Dispatchable<Origin=<Self as Trait<I>>::Origin> + From<Call<Self, I>>; | |||
| type Proposal: Parameter + Dispatchable<Origin=<Self as Trait<I>>::Origin> + From<frame_system::Call<Self>>; | |||
There was a problem hiding this comment.
The original statement allowed us to pass extrinsics from the module as a Proposal. In the benchmark, I opted to use System::remark instead as my generic proposal, so I placed the requirement that I can convert from frame_system::Call to proposal. This trait should always be satisfied for all pallets afaik
gui1117
reviewed
Apr 23, 2020
|
@thiolliere If things look good, would appreciate a green checkmark here |
gui1117
approved these changes
Apr 24, 2020
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a deep review with validation logic on some benchmarks to ensure that we are fully testing everything needed to sensibly weight these extrinsics and pallets.
Changes:
"*"syntaxUpdate Benchmarks for
Will update Offenses in a separate PR