Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Enable wasmtime only for x86_64 in substrate node #5432

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 27, 2020

When using the new feature of cargo cargo build -Z features=itarget,
the wasmtime feature will not bleed into the build for other
architectures.

We can do the same for Polkadot.

Fixes: #4188

CC @bjornwgnr @pepyakin @riusricardo

When using the new feature of cargo `cargo build -Z features=itarget`,
the `wasmtime` feature will not bleed into the build for other
architectures.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes labels Mar 27, 2020
Copy link
Contributor

@riusricardo riusricardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested on AArch64 🎉

@gavofyork gavofyork merged commit f541b01 into master Mar 27, 2020
@gavofyork gavofyork deleted the bkchr-wasmtime-target branch March 27, 2020 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasmtime fails to compile on ARM architectures.
3 participants