This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Prevent building invalid blocks #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A3-in_progress
arkpar
force-pushed
the
ark-block-builder-fix
branch
from
884fe20
to
0e17e47
Compare
pepyakin
reviewed
Jul 27, 2018
Cargo.toml
Outdated
| @@ -89,6 +89,3 @@ travis-ci = { repository = "paritytech/polkadot", branch = "master" } | |||
| maintenance = { status = "actively-developed" } | |||
| is-it-maintained-issue-resolution = { repository = "paritytech/polkadot" } | |||
| is-it-maintained-open-issues = { repository = "paritytech/polkadot" } | |||
|
|
|||
| [profile.release] | |||
| panic = "abort" | |||
There was a problem hiding this comment.
Even though panic=unwind is the default, I'd rather specify it explicitly with a comment for documentation purposes.
substrate/client/src/error.rs
Outdated
| @@ -111,6 +118,12 @@ error_chain! { | |||
| description("remote fetch failed"), | |||
| display("Remote data fetch has been failed"), | |||
| } | |||
|
|
|||
| /// Error decoding extrinsic outcome. | |||
| ApplyExtinsicFailed { | |||
There was a problem hiding this comment.
- I'm not sure why this is called
ApplyExtinsicFailed? I think it is more likeApplyResultDecodeFailed - Why the comment, description and display messages refers to an
outcomeand not to aresult?
substrate/client/src/error.rs
Outdated
| Runtime(e: ApplyError) { | ||
| description("Extrinsic error"), | ||
| display("Extrinsic error: {:?}", e), | ||
| } |
There was a problem hiding this comment.
Should we rename this to something more extrinsic-related. We could use ApplyExtinsicFailed for this IMO.
gavofyork
approved these changes
Jul 27, 2018
|
Would be nice to know why the transaction queue/block builder was letting blatantly invalid transactions through at all... |
gavofyork
added
A8-looksgood
and removed
A0-please_review
|
Transaction pool does not check for insufficient balance currently. And for signature correctness as far as I can see. |
dvdplm
added a commit
that referenced
this pull request
Jul 30, 2018
* master: (86 commits) Make contract a separate runtime module (#345) Version bump (#450) DB-based blockchain data cache for light nodes (#251) Update libp2p again (#445) Update version on git head change (#444) Fix the public key of bootnode 3 (#441) Update libp2p (#442) Switch to the master branch of libp2p (#427) Export ws port 9944 and add doc (#440) Iterate over overlay to decide which keys to purge (#436) Exit signal gets its own trait (#433) Add docker image (#375) Reset peers.json if the content is not loadable (#405) Limit number of incoming connections (#391) Fix memory leaks in libp2p (#432) Do not queue empty blocks set for import (#431) 5 random fixes (#1) (#435) Chore: fix typo (#434) Prevent building invalid blocks (#430) Better logging for public key mismatch (#429) ...
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* trigger pipeline in github-api for polkasync * update polkadot branch name for replacement * deployment: update project
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…tor-part-2 Refactor cirrus executor (part 2)
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* test-runtime: Fix README typo Signed-off-by: Alexandru Vasile <[email protected]> * test-runtime: Explicit error handling for missing substrate binary Signed-off-by: Alexandru Vasile <[email protected]> * test-runtime: Fix documentation typo Signed-off-by: Alexandru Vasile <[email protected]> * events: Test primitive decode_and_consume Signed-off-by: Alexandru Vasile <[email protected]> * events: Test tuple decode_and_consume Signed-off-by: Alexandru Vasile <[email protected]> * events: Test array decode_and_consume Signed-off-by: Alexandru Vasile <[email protected]> * events: Extend array with sequences Signed-off-by: Alexandru Vasile <[email protected]> * events: Test variant decode_and_consume Signed-off-by: Alexandru Vasile <[email protected]> * events: Test composite decode_and_consume Signed-off-by: Alexandru Vasile <[email protected]> * events: Test compact decode_and_consume Signed-off-by: Alexandru Vasile <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply_extrinsicreturn value is now considered by the block builder.panic=abortsince native runtime requires unwinding.