Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

The crate rename #4223

Merged
merged 7 commits into from
Dec 2, 2019
Merged

The crate rename #4223

merged 7 commits into from
Dec 2, 2019

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Nov 27, 2019

refs #4099 .

Rename crates in /primitives and /client: prefix them with with sp-and sc- respectively, remove any unnecessary suffixing -primitives, -runtime-api. Fixup all the used names inside the repo.

Upgrading

You'll find the bash script rename-crates-for-2.0.sh in the .maintain-folder. It is the script that was run and should be working the same way on your substrate-github-referencing project by renaming all the references in Cargo.toml and *.rs-files. You might have to cargo clean and build on a clean project again, if you encounter errors.

@gnunicorn
Copy link
Contributor Author

force pushed a new run of the script against master (rather than attempting to fix the enormous conflict)

@gnunicorn gnunicorn force-pushed the ben-the-crate-rename branch 2 times, most recently from 32ef1c3 to 985ba76 Compare November 29, 2019 10:40
@gnunicorn gnunicorn added this to the 2.0 milestone Nov 29, 2019
@gnunicorn gnunicorn force-pushed the ben-the-crate-rename branch from 985ba76 to 6f77e0a Compare December 2, 2019 08:33
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as is. I mostly focused my review on the script, as I suspect the rest is just the script being applied.

.maintain/rename-crates-for-2.0.sh Outdated Show resolved Hide resolved
.maintain/rename-crates-for-2.0.sh Show resolved Hide resolved
@gnunicorn gnunicorn merged commit 28c329e into master Dec 2, 2019
@gnunicorn gnunicorn deleted the ben-the-crate-rename branch December 2, 2019 10:23
@ascjones ascjones mentioned this pull request Dec 2, 2019
sorpaas pushed a commit that referenced this pull request Nov 20, 2020
* Adding script for rename, could be applicable for nodes on top of it, too

* add stderr and gitlab ci features

* apply script

* fix now minor details in expected stderr

* Update the Cargo.lock

* fix name: sc-transaction -> sc-tracing

* fix rename in script, too
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants