This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove footgun around session keys/handlers #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `OpaqueKeys` now has an associated type `KeyTypeIdProviders`. This can be used in the runtime as input for `SessionHandler` from the session trait. - `impl_opaque_keys` now works with modules and extracts the `KeyTypeId` from the module directly. - Added some checks to the `session` storage initialization that checks that the `SessionHandler` and `Keys` use the same number of keys and that the order is equal.
bkchr
requested review from
andresilva,
Demi-Marie and
kianenigma
as code owners
rphmeier
reviewed
Oct 28, 2019
core/sr-primitives/src/traits.rs
Outdated
| @@ -979,14 +979,14 @@ pub trait ValidateUnsigned { | |||
| fn validate_unsigned(call: &Self::Call) -> TransactionValidity; | |||
| } | |||
|
|
|||
| /// Opaque datatype that may be destructured into a series of raw byte slices (which represent | |||
| /// Opaque datatype that may be destructed into a series of raw byte slices (which represent | |||
There was a problem hiding this comment.
Destructured is correct here.
rphmeier
approved these changes
Oct 28, 2019
rphmeier
added
A8-looksgood
and removed
A0-please_review
bkchr
commented
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpaqueKeysnow has an associated typeKeyTypeIdProviders. This canbe used in the runtime as input for
SessionHandlerfrom the sessiontrait.
impl_opaque_keysnow works with modules and extracts theKeyTypeIdfrom the module directly.
sessionstorage initialization that checksthat the
SessionHandlerandKeysuse the same number of keys andthat the order is equal.