This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
srml: system: add kill_prefix #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
force-pushed
the
andre/system-kill-prefix
branch
from
bf17948 to
96c3bbf
Compare
andresilva
changed the title
andresilva
commented
Sep 30, 2019
| @@ -278,6 +278,13 @@ decl_module! { | |||
| storage::unhashed::kill(&key); | |||
| } | |||
| } | |||
|
|
|||
| /// Kill all storage items with a key that starts with the given prefix. | |||
| #[weight = SimpleDispatchInfo::FixedOperational(10_000)] | |||
There was a problem hiding this comment.
What should we set this to?
There was a problem hiding this comment.
it's entirely dependent on state, so we'd need a specialised weight type. and calculating it would take about as long as actually doing it, so kind of pointless. in any case it's root-only, so doesn't actually matter.
gavofyork
approved these changes
Oct 1, 2019
bkchr
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
kill_prefixextrinsic to system. This is useful to manually cleanup storage from double maps (needed as a result of #3724 but should be useful in general).