This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Extract smart-contract runtime into the separate crate #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
reviewed
May 31, 2018
substrate/runtime/staking/src/lib.rs
Outdated
(i32.const 4) ;; Pointer to "Transfer to" address. | ||
(i32.const 8) ;; Length of "Transfer to" address. | ||
(i32.const 12) ;; Pointer to the buffer with value to transfer | ||
(i32.const 8) ;; Length of the buffer with value to transfer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabs instead of spaces.
gavofyork
reviewed
May 31, 2018
substrate/runtime/staking/src/lib.rs
Outdated
;; Represented by u64 (8 bytes long) in little endian. | ||
(data (i32.const 4) "\02\00\00\00\00\00\00\00") | ||
;; Amount of value to transfer. | ||
;; Represented by u64 (8 bytes long) in little endian. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixed tabs/spaces
gavofyork
approved these changes
Jun 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs resolving and those bits of whitespace sorting.
pepyakin
force-pushed
the
ser-contract-extract-crate
branch
4 times, most recently
from
June 1, 2018 13:57
02a175b
to
fbcea41
Compare
one more little resolve... |
pepyakin
force-pushed
the
ser-contract-extract-crate
branch
from
June 4, 2018 07:55
fbcea41
to
b49884c
Compare
pepyakin
added
A8-looksgood
and removed
A0-please_review
Pull request needs code review.
labels
Jun 4, 2018
pepyakin
force-pushed
the
ser-contract-extract-crate
branch
from
June 5, 2018 09:29
b49884c
to
1aeeae8
Compare
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
provide redis msgbus
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Impl Mining Asset RPC * . * Rename XTypeAssetPowerMap to FixedAssetPowerOf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes in after #192
Smart-contract executing moved out from
substrate-runtime-staking
module.Hence
staking/src/contract.rs
is removed andstaking/src/mock.rs
is merged back intolib.rs
since it's used only inlib.rs
.