Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fixes CI #14763

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Fixes CI #14763

merged 1 commit into from
Aug 14, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Aug 14, 2023

No description provided.

@gupnik gupnik added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Aug 14, 2023
@gupnik gupnik requested review from a team August 14, 2023 11:06
liamaharon
liamaharon approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify.. we are removing because sp-core/std is not a dep of this crate in the first place correct?

@gupnik
Copy link
Contributor Author

gupnik commented Aug 14, 2023

To clarify.. we are removing because sp-core/std is not a dep of this crate in the first place correct?

Correct!

@ggwpez
Copy link
Member

ggwpez commented Aug 14, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 55302ba

@ggwpez
Copy link
Member

ggwpez commented Aug 14, 2023

Cumulus will be red because of paritytech/cumulus#2989, so we need to force merge this.

@ggwpez ggwpez mentioned this pull request Aug 14, 2023
Merged
@gupnik
Copy link
Contributor Author

gupnik commented Aug 14, 2023

bot merge force

@paritytech-processbot paritytech-processbot bot merged commit 3e8fc43 into master Aug 14, 2023
24 checks passed
@paritytech-processbot paritytech-processbot bot deleted the gupnik/ci-fix branch August 14, 2023 11:41
Ank4n pushed a commit that referenced this pull request Aug 20, 2023
@gupnik @Ank4n
Fixes CI (#14763)
3451985
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gupnik @ggwpez @bkchr @liamaharon