This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
chainHead_storage: Iterate over keys #14628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
added
A0-please_review
skunert
reviewed
Jul 25, 2023
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
tadeohepperle
approved these changes
Jul 25, 2023
| result: StorageResultType::Value(hex_string(&storage_data.0)), | ||
| }) | ||
| }) | ||
| QueryResult::Ok(opt.map(|storage_data| StorageResult::<String> { |
There was a problem hiding this comment.
Nit: I personally would just use Ok instead of QueryResult::Ok, but I guess that is just personal preference.
There was a problem hiding this comment.
(It might be that QueryResult::Ok is used here to convey the type information that comes along with QueryResult :))
jsdw
approved these changes
Jul 25, 2023
|
Thanks a lot for the review!
I thought of it as a hard limit to ensure we don't iterate over the whole DB until we implement the |
|
bot rebase |
|
Rebased |
|
bot rebase |
|
Branch is already up-to-date |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to iterate over (key, value) and (key, hash) pairs.
At the moment, substrate will iterate over at most 10 keys producing at most 10 pairs.
This PR lays the ground for iteration and support for pagination will be added in:
A new tests checks
Closes #14548.
// @paritytech/subxt-team