Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

wasm-builder: Make hash and date optional #14490

Merged
merged 2 commits into from
Jul 3, 2023
Merged

wasm-builder: Make hash and date optional #14490

merged 2 commits into from
Jul 3, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jul 2, 2023

Apparently there are installations where the hash and date is optional.

Closes: #14335

@bkchr
wasm-builder: Make hash and date optional
4c0db1c 
Apparently there are installations where the `hash` and `date` is optional.

Closes: #14335
@bkchr bkchr added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels Jul 2, 2023
@bkchr bkchr requested a review from a team July 2, 2023 13:10
@bkchr bkchr requested a review from koute as a code owner July 2, 2023 13:10
@bkchr bkchr requested a review from a team July 2, 2023 21:58
@bkchr
Copy link
Member Author

bkchr commented Jul 3, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 3, 2023 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3105559 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 9-adce1797-fb28-4b36-81ed-c0d7c64161a6 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 3, 2023

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3105559 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3105559/artifacts/download.

@bkchr
Copy link
Member Author

bkchr commented Jul 3, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit d53b1f3 into master Jul 3, 2023
@paritytech-processbot paritytech-processbot bot deleted the bkchr-wasm-builder-optional-hash-and-date branch July 3, 2023 09:58
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
wasm-builder: Make hash and date optional (paritytech#14490)
0d6377b 
* wasm-builder: Make `hash` and `date` optional

Apparently there are installations where the `hash` and `date` is optional.

Closes: paritytech#14335

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@davxy davxy davxy approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest node template fails to build
4 participants
@bkchr @koute @michalkucharczyk @davxy