This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sp-api: Set correct where bound in the generated code #14252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.
bkchr
added
A0-please_review
koute
approved these changes
May 29, 2023
bkchr
added
the
D3-trivial 🧸
lexnv
approved these changes
May 29, 2023
|
bot merge |
|
Waiting for commit status. |
|
@bkchr could you cherry-pick this commit into polkadot-v0.9.42 and polkadot-v0.9.43 branch? |
bkchr
added a commit
that referenced
this pull request
May 29, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.
|
@koushiro done. |
|
@bkchr I'm using polkadot-v0.9.42 branch, could you update it, please |
bkchr
added a commit
that referenced
this pull request
May 29, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.
|
Done, sorry I had forgotten to push the branch 🙈 |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.
vanderian
pushed a commit
to gasp-xyz/substrate
that referenced
this pull request
Jul 26, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The where bound for the
create_metadatafunction wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.Closes: #14250