Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sp-wasm-interface: remove useless wasmi impl #14208

Merged
merged 3 commits into from
May 29, 2023
Merged

sp-wasm-interface: remove useless wasmi impl #14208

merged 3 commits into from
May 29, 2023

Conversation

koushiro
Copy link
Contributor

Since the wasmi backend has been removed from sc-executor, so I don't think it's necessary to keep the wasmi_impl part in sp-wasm-interface

@koushiro koushiro requested a review from koute as a code owner May 24, 2023 06:19
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels May 24, 2023
@koushiro
Copy link
Contributor Author

@koute PTAL

@koute
Copy link
Contributor

koute commented May 29, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkchr
Copy link
Member

bkchr commented May 29, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 48817b5 into paritytech:master May 29, 2023
@koushiro koushiro deleted the remove-useless-wasmi-impl branch May 29, 2023 10:33
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants