This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Easy PR: Fix warnings from latest nightly #14195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
May 23, 2023
sam0x17
approved these changes
May 23, 2023
davxy
approved these changes
May 23, 2023
bkchr
approved these changes
May 23, 2023
Requires master merge. |
KiChjang
approved these changes
May 23, 2023
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 3e504d6 |
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
* unneeded mut * remove needless borrows
15 tasks
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
* unneeded mut * remove needless borrows
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* unneeded mut * remove needless borrows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unneeded
mut
s removed.Removed needless
.borrow()
s. (Two seemed to be needed so these I switched to just use an&
)Now compiles without warnings on latest nightly.